Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Template Resolvers for response generations #114

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Adding Template Resolvers for response generations #114

merged 1 commit into from
Aug 23, 2019

Conversation

Shreyas-vgr
Copy link
Contributor

Description

Adding Template Resolvers for response generations

Motivation and Context

The ASK SDK handles request from Alexa Skill VUI by routing it to specific handler and builds up response to send back. Currently it uses ResponseBuilder to construct a response.

Template concept has been popular and powerful in web app development, where web designers and developers can work together to automatically generate customized web pages, by injecting dynamic content data into static template, which contains common components like header, footer, navigation bar etc.

Similarly, template concept can be introduced to Alexa Skill development, so that voice application designers and developers can work together to automatically generate customized skill responses

Testing

tox command success
mypy success

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@Shreyas-vgr Shreyas-vgr requested review from nikhilym and a team August 23, 2019 00:12
@Shreyas-vgr Shreyas-vgr requested review from a team and nikhilym August 23, 2019 00:43
Copy link
Contributor

@nikhilym nikhilym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 :shipit:

@nikhilym nikhilym requested a review from a team August 23, 2019 00:52
@nikhilym nikhilym added enhancement New feature or request feature-request:sdk SDK specific Feature Request labels Aug 23, 2019
@nikhilym nikhilym merged commit 72e1adb into alexa:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature-request:sdk SDK specific Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants