Send data to ServiceClients only if present #39
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes to the default API client class, so that the raw data is sent to the Alexa service clients only if the
request.body
is not null. Without that,requests
library calls leads to incorrect content type for responses, as mentioned in #38 .The PR also includes scoping requests library to <= 2.19.1, which scopes urllib3 < 1.24, without which the
standard
anddynamo
package installations might fail. This can be checked from the build failure of docs hereMotivation and Context
#38
Testing
Ran sdk tests using
scripts/ci/run_tests
Screenshots (if appropriate)
Types of changes
Checklist
License