Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper function for matching CanFulfill Intent name #46

Merged
merged 1 commit into from Nov 14, 2018

Conversation

timothyaaron
Copy link
Contributor

Description

Provide matching helper function for IntentRequest-specific is_intent_name() to CanFulfillIntentRequest... for use in can_handle().

Motivation and Context

Follow DRY principles.
Simply intent matching.

i.e.,

return (
    is_request_type('CanFulfillIntentRequest')(handler_input) and
    handler_input.request_envelope.request.intent.name == 'MyIntent'
)

to...

return is_canfulfill_intent_name('MyIntent')(handler_input)

Testing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nikhilym nikhilym added the feature-request:sdk SDK specific Feature Request label Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request:sdk SDK specific Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants