Makes attribute_map optional for serializing #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of having duplicated keys between
attribute_map
anddeserialized_types
, this PR allows to completely leave outattribute_map
in serialized classes, if you don't want to do any renaming between the native and serialized representations.An example:
Motivation and Context
This PR is a follow-up on the discussion in #58. I'm using the serializer in my projects too, as I found it super useful. However I found the repetition of attribute names unnecessary and decreasing the readability of my models.
Testing
I ran the tests locally (OS X, py3.6), all passed. Note I didn't add new tests to cover this functionality as it is only in discussion/evaluation phase. I'm happy to add some if you find the change acceptable.
Types of changes
Checklist
License