Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add proxy support for smapi commands #434 #465

Merged
merged 5 commits into from May 15, 2023
Merged

feat: add proxy support for smapi commands #434 #465

merged 5 commits into from May 15, 2023

Conversation

doiron
Copy link
Contributor

@doiron doiron commented Apr 22, 2023

#434

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@doiron doiron requested a review from tydonelson April 22, 2023 01:10
@doiron doiron force-pushed the proxy-bug branch 5 times, most recently from f74115d to ad4ee87 Compare May 8, 2023 21:01
@doiron doiron marked this pull request as ready for review May 11, 2023 04:13
@doiron doiron requested a review from LucioMS May 11, 2023 22:31
lib/utils/logger-utility.js Outdated Show resolved Hide resolved
lib/utils/logger-utility.js Outdated Show resolved Hide resolved
Copy link
Contributor

@tydonelson tydonelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small nit you can take or leave

lib/clients/smapi-client/smapiApiClient.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from tydonelson May 15, 2023 22:04
@doiron doiron merged commit 87e315d into develop May 15, 2023
14 checks passed
@doiron doiron deleted the proxy-bug branch May 15, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants