fix: skill creation and clone returns 'no skill repository found' #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tydonelson
requested review from
doiron,
LucioMS and
CamdenFoucht
and removed request for
doiron,
LucioMS and
CamdenFoucht
tydonelson
force-pushed
the
corrections-2023-03
branch
from
78dba57
to
4748905
Compare
tydonelson
changed the title
doiron
reviewed
Apr 4, 2023
Comment on lines
+48
to
+49
| gitHelper.checkoutBranch("prod") | ||
| gitHelper.checkoutBranch("master"); |
There was a problem hiding this comment.
I see it was doing the same as well before. I just don't understand why it's doing this branch change twice. some hack to pull both down locally I presume?
There was a problem hiding this comment.
Right, I believe the purpose is to pull both down locally and have the upstream set
doiron
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #234
Description
The built-in vscode APIs for git management are failing to retrieve repositories in our environment, so for now we will fall back to executing git via the shell (some operations were already running through the shell).
Adds a
getCurrentBranchoperation to the git terminal helper to facilitate the transition.Also contains some ESLint corrections in the file
src/utils/cloneSkillHelper.ts, mostly around usage before declaration.Testing
Manually tested, as well as added a unit tests around git helper functions:
Screenshots (if appropriate)
Types of changes
Checklist
License