Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute store conflicts with other frame attributes #6

Closed
Sayid1 opened this issue Apr 9, 2019 · 9 comments
Closed

Attribute store conflicts with other frame attributes #6

Sayid1 opened this issue Apr 9, 2019 · 9 comments

Comments

@Sayid1
Copy link

Sayid1 commented Apr 9, 2019

Hi,
The store is a very common attribute that I have been using with other frameworks.

I'm trying to rename the store property and send a new one package

@alexander-heimbuch
Copy link
Owner

Could a configurable property name on the instance an option for you?

@Sayid1
Copy link
Author

Sayid1 commented Apr 10, 2019

Actually, store is property of other frameworks, is not configurable

@Sayid1
Copy link
Author

Sayid1 commented Apr 10, 2019

To avoid conflicts with other frameworks, why not put a special symbol in front of it?

@alexander-heimbuch
Copy link
Owner

I was referring to introduce a configuration in redux-vuex also a prefix won't prevent a potential conflict. So by default the binding would be this.store, but you could configure it in the connect call, like so:

connect({ 
  Vue,
  store,
  binding: 'myStore'
})

@Sayid1
Copy link
Author

Sayid1 commented Apr 11, 2019

this.store = store

I see this in the code,

@alexander-heimbuch
Copy link
Owner

Yes, I'm asking you if a configurable store binding would fit your use case. It is not implemented yet.

@Sayid1
Copy link
Author

Sayid1 commented Apr 11, 2019

Sure,of course. That would be great!

@weboAp
Copy link

weboAp commented May 14, 2019

+1

@alexander-heimbuch
Copy link
Owner

released in 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants