Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make context scanning more robust to unfinished forms #53

Closed
alexander-yakushev opened this issue Apr 27, 2018 · 6 comments
Closed

Make context scanning more robust to unfinished forms #53

alexander-yakushev opened this issue Apr 27, 2018 · 6 comments

Comments

@alexander-yakushev
Copy link
Owner

This should enable locals completion for those who don't use Paredit, inlcuding rebel-readline (see bhauman/rebel-readline#28).

@didibus
Copy link

didibus commented Nov 11, 2018

I came here to suggest such a feature.

I often type unbalanced forms like:

(let [things 20]
 thi  ;; <- This does not get auto-completed

And would love it if the auto-completion could still work.

I'd even be okay with something more stupid, like basic word completion that uses the 20 previous lines or something like that, in the case the form can't be parsed.

@arichiardi
Copy link
Contributor

My 2c, I like local let completions but the "dumb" word completion should not be part of this library but part of the editor. You risk duplicating things, for instance company-mode for Emacs already does that.

@didibus
Copy link

didibus commented Nov 11, 2018

@arichiardi I'm coming specifically form Emacs. At least with Cider, it doesn't seem to fallback to normal text completion.

Do you know if there's a way to set it up? Specifically, so it only falls back to normal text completion when compliment could not complete it?

@arichiardi
Copy link
Contributor

Yep it should be like that, compliment is only one of the completion providers of company-mode

@didibus
Copy link

didibus commented Nov 11, 2018

@arichiardi Hum, so you're saying something is messed up with my Emacs settings? Do you know where I should look for trying to root cause this then?

@alexander-yakushev
Copy link
Owner Author

Should be working now as of 0.3.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants