Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed FieldsArray.push to preserve the order of input items #104

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Fixed FieldsArray.push to preserve the order of input items #104

merged 1 commit into from
Feb 21, 2022

Conversation

zhenwenc
Copy link
Contributor

@zhenwenc zhenwenc commented Feb 19, 2022 •
edited by alexandercerutti

PR to fix the reported issue: #103

In the generated passes, the fields (eg: primaryFields, secondaryFields) appear in reverse order compared to the original source in pass.json.

Fixes #103

@zhenwenc zhenwenc mentioned this pull request Feb 19, 2022
Closed
alexandercerutti
alexandercerutti requested changes Feb 19, 2022
View reviewed changes
src/FieldsArray.ts Outdated Show resolved Hide resolved
@alexandercerutti alexandercerutti merged commit df02c87 into alexandercerutti:master Feb 21, 2022
@zhenwenc zhenwenc deleted the fix-field-array-order branch February 22, 2022 07:19
@alexandercerutti alexandercerutti added the bug Something isn't working label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandercerutti alexandercerutti alexandercerutti approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Field order in the loaded pass.json is not preserved
2 participants
@zhenwenc @alexandercerutti