-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added firebase example #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution. This is wonderful, also I have several doubts although I'd rather have it in Typescript (but I guess I could convert it later).
What I noticed missing is a README.md
file that explains how to use this example. If you want to write it, I can do it, but I need first to understand how everything in here works.
What I care about the most is that we are able to run it successfully both locally and on a cloud function, so it's code must be suitable for both envs.
Sure, makes sense. Yes if you wouldn't mind writing a README for it that would be amazing, I'll try my best to explain everything. As I mentioned earlier, I am an iOS developer primarily and not too familiar with the backend side of things, so I more than likely haven't done certain things properly, and would love some help navigating some of these things so I can learn from it myself as well :) |
Yeah, no problem at all! Help me however you can ;) |
Added peer dependency, scripts to package.json, and added error logs, removed webServiceURL and auth token
…to use npx firebase
I've partially reviewed the code you made right now:
Since I've pushed on your branch, be sure to pull first if you want to make more changes |
Okay so, I was able to set up everything, deploy the function, and give the permission to be publicly accessed on the web (for future ref: https://cloud.google.com/functions/docs/securing/managing-access-iam?hl=it#console, with role What I'm stuck on right now (I have to check better) is that the model as-is cannot be found on that path, because the model does not get uploaded. Maybe we can copy the model folder on |
Okay, I was able to overcome this block. Thank you very much for your contribution @Saim-Khan1! |
Hi @alexandercerutti, I was taking a little break, really sorry I missed all of this! Just having a quick read-through, looks like you managed to work through everything which is great, again really sorry I couldn't be of more help 😅 |
Description
Added a quick Firebase example, based on #150, which initialises the firebase admin, downloads images stored in Firebase Cloud Storage to add to the pass (and deletes these once complete) and serves the pass directly as the response.
Check relevant checkboxes
npm test
) and they passed