changed method invocation amse.toggle_check_node() to toggle_check_no… #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de(), removing the object name from the method call in toggle-checked-state-on-label-click.js. That prefix is causing *NOT* to trigger the method properly.
| @@ -1,2 +1,3 @@ | |||
| demo/ | |||
| node_modules/ | |||
| /.project | |||
There was a problem hiding this comment.
can you remove this from the commit?
|
Indeed, nice catch! I'll merge once the |
|
Your second commit removed too much things. Please put back the as those existed before your patch. |
|
Didn't see this last commit of yours, sorry for that! Merging |
|
Thanks ! Em dom, 5 de jun de 2016 às 20:14, Alexander Nestorov <
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…de(), removing the object name from the method call in toggle-checked-state-on-label-click.js.
That prefix is causing NOT to trigger the method properly.