Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the photos could have metadata about where face is, used for cropping #2

Open
mkf opened this issue Jul 22, 2019 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@mkf
Copy link

mkf commented Jul 22, 2019

the photos could have metadata about where face is, used for better cropping

additional routines could be written to do viewbox differently when there is such info attached for a given photo

2019-07-22-123619_1016x244_scrot

ofc iknow iknow that's a facultative feature and without it it's all still great

and i guess it was probably totally a conscious decision during the development, not to do that at the time

i hope it's not too bad that i just, maybe too boldly, put the idea here and not contribute doing it myself (since i guess i would have some chances in doing it with enough effort but rn i just don't feel like doing it, also i'm not a user of placekeanu really myself although i know people who totally are gonna be using it)

i mostly just do it thinking of people who might be stumbling into issues and maybe will be eager to do it

@alexandersandberg
Copy link
Owner

@mikrfe You're right—the cropping could be improved. At the moment it's only looking for a photo of the correct rotation when the width/height ratio is too far off from a square while centering everything width- and height wise.

I appreciate the suggestion! I'll keep the issue open as it's something I—or possibly someone else—would consider working on in the future.

@alexandersandberg alexandersandberg added the enhancement New feature or request label Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
PlaceKeanu v2
  
To do
Development

No branches or pull requests

2 participants