Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organized Folder Structure, and Added Redux-Logger #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amanuel2
Copy link

Thanks for this cool boilerplate. This(with changes in PR) will be the boilerplate I would use so thought I would help out!

@vercel
Copy link

vercel bot commented Nov 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/alexandr-g/cra-template-typescript-redux/4y2wszoq9
✅ Preview: https://cra-template-typescript-redux-git-master.alexandr-g.vercel.app

@alexandr-g
Copy link
Owner

alexandr-g commented Dec 6, 2020

Hey @amanuel2,

I think you're using a different approach for organizing files which is by no means wrong. I'm using a feature-based approach which is strongly recommended in the Redux docs https://redux.js.org/style-guide/style-guide/#structure-files-as-feature-folders-or-ducks

Also, it's mentioned in the readme - https://github.com/alexandr-g/cra-template-typescript-redux#redux-configuration

I do understand that using this approach might not be comfortable for everyone - therefore I'll leave this PR open as an example of the alternative 🙂

Thanks for your contribution!

@@ -0,0 +1,16693 @@
{
"name": "cra-template-typescript-redux",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're using npm it's totally fine to commit package-lock.json. I'm using yarn which has its own lock file yarn.lock and it's not recommended to have both of them, hence mixed up npm and yarn.

@@ -18,6 +18,7 @@
"redux",
"react-redux",
"react-router",
"redux-logger",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the idea of adding redux-logger 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants