This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
Add support for last position marker #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 25, 2020 22:35
…nto add-markers-with-antpath-plusCenter_on_first_position
…t-position-marker
# Conflicts: # CHANGELOG.md # README.md # dist/README.md # dist/module.js # dist/module.js.map # dist/plugin.json # package.json # src/TrackMapPanel.tsx # src/module.ts # src/types.ts
Alkarex
approved these changes
Nov 5, 2020
|
Thanks for the PR @CodeFunta! Nice work. It was no longer possible to show the regular icon on all markers, so I made a few changes. It uses a "secondary icon" instead of a "last icon", which makes it more flexible if we want to do more things with the icons. I changed the config switches to match this, and made it so the "markers" and "ant path with markers" views have the same options. You should still be able to achieve the same views as before my changes (and more). I also put the default icon back, as I don't want to change it to a custom one. |
|
@CodeFunta Your code is included in the newest release 2.1.0 (please give it a try and let us know), which is currently under review at Grafana grafana/grafana-plugin-repository#766 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.