This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
Added marker icon customization option (#53) #55
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
As promised in issue #53, I've been working on an easier way to customize the marker icons directly in the Grafana dashboard.
The changes introduce the functionality to adjust the global and point-specific marker styles without the need to rebuild the plugin (for a full explanation of the feature, please refer to my changes to the README.md):
Here's my (more or less) detailed list of changes:
Added grouping for config options (General, Markers, Ant Path, Heat):
![grouped-config](https://user-images.githubusercontent.com/47070812/113599425-e344ae80-963e-11eb-9ea0-86e46fd88e44.png)
Migrated to SVG icon (now defined inline with fully customizable color)
Added config options for default (primary) & secondary marker icons:
![marker-style-config-global](https://user-images.githubusercontent.com/47070812/113599494-f9eb0580-963e-11eb-88b4-076c5525663b.png)
Usage of useMemo for createMarkers to improve performance
Fixed invalid colors for Ant Paths (now using hex colors instead of the unsupported color names from Grafana)
Once again, feedback is highly appreciated :)
Best regards!
Tim