-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: continuous recording (resilient against failing streams) #139
Merged
jdpigeon
merged 5 commits into
alexandrebarachant:master
from
ErikBjare:dev/continuous-record
Feb 14, 2021
Merged
feat: continuous recording (resilient against failing streams) #139
jdpigeon
merged 5 commits into
alexandrebarachant:master
from
ErikBjare:dev/continuous-record
Feb 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikBjare
force-pushed
the
dev/continuous-record
branch
3 times, most recently
from
December 2, 2020 15:05
2e78b01
to
147f402
Compare
For appending, all you'd need to do is check if the file already exists and continuous mode is on. If so, use kwargs |
I've merged this into https://github.com/xloem/muse-lsl . |
ErikBjare
force-pushed
the
dev/continuous-record
branch
from
February 7, 2021 11:01
147f402
to
c323c1f
Compare
ErikBjare
changed the title
feat: started working on continuous recording (to make resilient against failing streams)
feat: continuous recording (resilient against failing streams)
Feb 7, 2021
As a Muse 'old head' with a stack of 'original' non-BLE Muse 2014s laying around, I simply must correct this. Let's call the 2016 version the 'classic' version.
Awesome. Thanks so much for this. Our original implementation was really quite shaky for collecting longer sessions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be of interest to you @JohnGriffiths
Note: not actually 'continuous', it just saves every 10s. Ideally, it'd append rows into the CSV file instead of rewriting the entire file (but since a DataFrame is used this would require more extensive rewriting).TODO
black
should be applied in separate commit, or skipped altogether