chore: fixing issues with accessibility and seo on the last lighthous…

…e report
alexandrecanijo · Sep 8, 2022 · 3d73cfa · 3d73cfa
1 parent 36940f7
commit 3d73cfa
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 4 deletions.
diff --git a/components/Tutorial.vue b/components/Tutorial.vue
@@ -12,6 +12,8 @@
         class="flex justify-center pt-8 sm:pt-0"
         href="https://nuxtjs.org"
         target="_blank"
+        title="nuxtjs.org"
+        aria-label="nuxtjs.org"
       >
         <svg
           width="218"
@@ -76,7 +78,11 @@
         </p>
       </div>
       <div class="flex justify-center pt-4 space-x-2">
-        <a href="https://github.com/nuxt/nuxt.js" target="_blank"
+        <a
+          href="https://github.com/nuxt/nuxt.js"
+          target="_blank"
+          title="nuxt.js github repository"
+          aria-label="nuxt.js github repository"
           ><svg
             class="w-6 h-6 text-gray-600 hover:text-gray-800 button--github"
             xmlns="http://www.w3.org/2000/svg"
@@ -93,7 +99,11 @@
               fill="currentColor"
             /></svg
         ></a>
-        <a href="https://twitter.com/nuxt_js" target="_blank"
+        <a
+          href="https://twitter.com/nuxt_js"
+          target="_blank"
+          title="nuxt.js twitter"
+          aria-label="nuxt.js twitter"
           ><svg
             class="w-6 h-6 text-gray-600 hover:text-gray-800"
             xmlns="http://www.w3.org/2000/svg"
@@ -120,3 +130,14 @@ export default {
   name: 'NuxtTutorial',
 }
 </script>
+
+<style scoped>
+.text-green-500 {
+  color: #075f40;
+}
+
+.text-2xl,
+.text-gray-600 {
+  color: #000;
+}
+</style>
diff --git a/nuxt.config.js b/nuxt.config.js
@@ -2,16 +2,23 @@ export default {
   // Target: https://go.nuxtjs.dev/config-target
   target: 'static',
 
+  modern: ({ isDev }) => !isDev,
+
   // Global page headers: https://go.nuxtjs.dev/config-head
   head: {
-    title: 'nuxt2-lighthouse-boilerplate',
+    title: 'Nuxt2 Lighthouse Boilerplate',
     htmlAttrs: {
       lang: 'en',
     },
     meta: [
       { charset: 'utf-8' },
       { name: 'viewport', content: 'width=device-width, initial-scale=1' },
-      { hid: 'description', name: 'description', content: '' },
+      {
+        hid: 'description',
+        name: 'description',
+        content:
+          'Nuxt2 Boilerplate with performance in mind, trying to achieve 100% on Lighthouse',
+      },
       { name: 'format-detection', content: 'telephone=no' },
     ],
     link: [{ rel: 'icon', type: 'image/x-icon', href: '/favicon.ico' }],