Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added notification when form is not complete #67

Merged
merged 1 commit into from
May 3, 2021
Merged

Conversation

alexandrelam
Copy link
Owner

Feature

Display red notification in the right corner if the form is not complete when creating an event.

resolve #66

@alexandrelam alexandrelam added the enhancement New feature or request label May 3, 2021
Copy link
Collaborator

@AlexisAoun AlexisAoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, future work could be done on more descriptive messages, possible integration with backend error system

@AlexisAoun AlexisAoun self-requested a review May 3, 2021 18:38
Copy link
Collaborator

@AlexisAoun AlexisAoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me

@AlexisAoun AlexisAoun merged commit 29bb9fd into main May 3, 2021
@AlexisAoun AlexisAoun deleted the add_notification branch May 3, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add notification when event is not created
2 participants