Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags feature is not working #48

Closed
boredhero opened this issue Oct 4, 2023 · 4 comments · Fixed by #49
Closed

Tags feature is not working #48

boredhero opened this issue Oct 4, 2023 · 4 comments · Fixed by #49
Assignees
Labels
enhancement New feature or request

Comments

@boredhero
Copy link

the genres (which I presume would be representative of tags) for NHentai, is returning an empty list always. This makes it impossible to filter results by tags.

@AlexandreSenpai AlexandreSenpai added the enhancement New feature or request label Oct 4, 2023
@boredhero
Copy link
Author

Also noticed author is always returning null.

@AlexandreSenpai AlexandreSenpai linked a pull request Oct 4, 2023 that will close this issue
@AlexandreSenpai AlexandreSenpai self-assigned this Oct 4, 2023
@AlexandreSenpai
Copy link
Owner

This is the new representation example of a Manga from Enma's NHentai Source:

Manga(id=184536,
      created_at=datetime.datetime(2023, 10, 4, 1, 49, 20, 886944),
      updated_at=datetime.datetime(2023, 10, 4, 1, 49, 20, 886950),
      title=Title(english='(C91) [sagejoh (sage joh)] Chichimonogatari '
                          '(Bakemonogatari) [English] [EYEPOP]',
                  japanese='(C91) [サゲジョー (sage・ジョー)] 乳物語 (化物語) [英訳]',
                  other='Chichimonogatari'),
      authors=['sage joh'],
      genres=[Genre(name='ffm threesome', id=15348),
              Genre(name='group', id=8010),
              Genre(name='big breasts', id=2937),
              Genre(name='defloration', id=20525),
              Genre(name='glasses', id=8378),
              Genre(name='schoolgirl uniform', id=10314),
              Genre(name='sole male', id=35763)],
      chapters=[Chapter(id=0,
                        pages=[Image(uri='https://i.nhentai.net/galleries/1017086/1.jpg',
                                     width=1276,
                                     height=1800),
                               Image(uri='https://i.nhentai.net/galleries/1017086/2.jpg',
                                     width=419,
                                     height=600),
                               Image(uri='https://i.nhentai.net/galleries/1017086/3.jpg',
                                     width=1242,
                                     height=1800)])],
      chapters_count=1,
      cover=Image(uri='https://t.nhentai.net/galleries/1017086/cover.jpg',
                  width=350,
                  height=494),
      thumbnail=Image(uri='https://t.nhentai.net/galleries/1017086/thumb.jpg',
                      width=250,
                      height=353))

Manganato follows the same recipe. In the future i'm going to implement genre/tag filter at doujin search for NHentai source.

Thank you for opening this issue and for using Enma. (*  ̄︿ ̄)

@AlexandreSenpai
Copy link
Owner

You can upgrade enma to v2.1.2 using

pip install --upgrade enma

@boredhero
Copy link
Author

You can upgrade enma to v2.1.2 using

pip install --upgrade enma

You're a real G, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants