Match all valid variables; sort variable; tabs over spaces #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexrudd can you please add description? thanks for pr |
|
Noticed a couple more bugs: Should now handle variables with upper-case letters and lines containing more than one variable |
alexandrst88
approved these changes
May 24, 2018
| @@ -17,10 +17,9 @@ var tfFileExt = "*.tf" | |||
| var dstFile = "./variables.tf" | |||
| var varTemplate = template.Must(template.New("var_file").Parse(`{{range .}} | |||
| variable "{{ . }}" { | |||
| description = "" | |||
| description = "" | |||
There was a problem hiding this comment.
this is not proper format, when you run terraform fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for creating this tool!
Firstly I had some trouble when running it against variables with numerical characters so I changed the regex matcher to use the same pattern that Terraform uses.
Secondly I added a sort function so that the variables are written to file in order.
And finally I changed the indentation of the variable blocks to use a single tab instead of three spaces. This matches what
terraform fmtwould do.