Add go modules and refactor packages #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gordonbondon can you please divide the actual code changes and go mod introduction into two different commits to simplify the review? |
hatemosphere
reviewed
Apr 2, 2019
| "fmt" | ||
| "os" | ||
|
|
||
| "github.com/spf13/cobra" |
There was a problem hiding this comment.
what are your thoughts about cobra vs kingpin?
There was a problem hiding this comment.
https://github.com/alecthomas/kingpin last commit 9 month ago, either it's perfect or dead. I'll check if we can use it.
Closed
|
@hatemosphere changes were split into two commits |
Fix linter errors
|
thanks @gordonbondon 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.