enable low-level optimization #23
Conversation
| @@ -24,6 +24,8 @@ import net.spy.memcached.ops.OperationQueueFactory | |||
| * @param operationTimeout is the default operation timeout; When the limit is reached, the | |||
| * Future responses finish with Failure(TimeoutException) | |||
| * | |||
| * @param shouldOptimize If true, low-level optimization is in effect. | |||
There was a problem hiding this comment.
Took me a while to track down exactly what happens if this is true, but it seems at the end of the day this option gets propagated to the MemcachedConnection, where, the effect is:
If true, optimisation will collapse multiple sequential get ops.
Can you please add that that description into the parameter ScalaDoc ?
There was a problem hiding this comment.
I dit it.
How does that look?
enable low-level optimization
|
👍 but guys, what's the default in SpyMemcached? Assuming no downsides, wouldn't it be more beneficial to default to true? |
|
@alexandru: Both In the interests of safety I think we should keep it as |
|
OK, then |
enable low-level optimization
enable low-level optimization
I'd like to use
ConnectionFactory.shouldOptimize().