Fix signature encoding #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that GCP requires percent encoding for characters such as `+` and `/`, or otherwise the request will fail with a complaint that the Signature was not base64 encoded. Related issue: alexandrubagu#7
Pull Request Test Coverage Report for Build e86221eb86b7e479778ad7f36a88d31bec71c3ce-PR-16
💛 - Coveralls |
|
And suddenly #7 makes sense. :) I guess that's the reason the signatures are base16 encoded on the newer v4 algorithm. Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that GCP requires percent encoding for characters such as
+and
/, or otherwise the request will fail with a complaint thatthe Signature was not base64 encoded.
Related issue: #7