Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Range selector vs Zoom level #34

Closed
Mariusthvdb opened this issue Apr 15, 2022 · 10 comments
Closed

Range selector vs Zoom level #34

Mariusthvdb opened this issue Apr 15, 2022 · 10 comments
Labels
enhancement New feature or request

Comments

@Mariusthvdb
Copy link

Schermafbeelding 2022-04-15 om 14 57 46

not a strict 'issue' as such I think, but since we have no 'discussion' tab, please allow here.

I must confess I keep being surprised by the way the + and - behave on the top right tool. I would expect a + to widen the range, and vv.

Don't have to describe it any better than that I think.

ofc, it shows the Lense/magnifier, and is probably a zoom level, like on the Maps. In this context however, I would rather use a range specifier myself, so that might explain the mindbend I experience when ever I click it ;-)

Anyways, maybe you could consider it.
thanks!

@alexarch21
Copy link
Owner

Yeah I mean it's just a convention, i had to pick one. It's indeed designed like maps, which for me feels natural. But I can see how this can be awkward if you 'just work' the other way round. I can add a toggle in the next release, not a big deal.

@alexarch21 alexarch21 added the enhancement New feature or request label Apr 15, 2022
@alexarch21
Copy link
Owner

So uhm, for people whos brains work the wrong other way round for zoom-related UI content ;) How would you see that working exactly in the toolbar ? Just swap the behavior of the existing buttons (- would zoom in and + zoom out) but keep the icons in the same order in the UI ? Or swap them around in the UI too, so have the + left and the - at the right ?

@Mariusthvdb
Copy link
Author

Mariusthvdb commented Apr 25, 2022

uhm too....
I guess, the position of the buttons wouldn't really matter?

+ means more (history in this case), so zoom out. and vice versa

Maybe give the icon placeholder a function? right now, there's the magnifier. If that is selected, it would behave as on Maps.

+ meaning zooming in (more detail) - zooming out (less detail).

but, click the icon, and have Magnifier change to eg mdi:calendar-search, make it behave like:

+ meaning more range, - meaning less range ?

clicking the magnifier icon now does nothing (as far as I can see) other than darken it?

This would require no more space, wouldn't change the buttons, merely add functionality to the current icon placeholder (and maybe a hover popup to explain, just incase...)

@alexarch21
Copy link
Owner

alexarch21 commented Apr 25, 2022

I don't think I will put in additional logic in the toolbar for this, that would be overengineering it. Just a YAML toggle that swaps the + and the - behavior. The question is, should this also swap the position of the two icons on the toolbar.

clicking the magnifier icon now does nothing (as far as I can see) other than darken it?

The magnifier icon activates interactive zoom mode. Click it (it becomes dark, means active) then select and drag a range in one of your graphs with your mouse and it will zoom into the selected range. Check out the video in the readme, it shows how to use it.

@Mariusthvdb
Copy link
Author

sorry, I missed that interactive zoom mode functionality.

about the positioning, I wouldn't have any definitive suggestions there I am afraid, what would be your reasoning?
(I guess the beauty of my suggestions would be that there would be no other change in the frontend than the icon change and its related functionality. Holding on to that, I would suggest not changing the position?)

@emufan
Copy link

emufan commented Apr 29, 2022

But please only an option, not a replacement of the current +/-.

For me the + = zoom in, - zoom out as in maps is much more intuitive,

Do you use it in other way in google maps, Marius? ;-)

@Mariusthvdb
Copy link
Author

sure, optional. A yaml toggle, as suggested by #34 (comment)

@alexarch21
Copy link
Owner

Yeah it's gonna be a toggle, default is the current behavior. I'm also used to the map zoom style myself.

Probably going to upload the next release with several small fixes this weekend.

@alexarch21
Copy link
Owner

Added a toggle to V1.0.22:

uiLayout:
  invertZoom: true

false is default behavior. true inverts it, + will now zoom out, - will zoom in.

@denilsonsa
Copy link

Hmm… I think I understand the confusion. Look at these mock-ups:

[-] [🔍] [+] [ 1 day ⏷]

[🔍] [-] [ 1 day ⏷] [+]

The first one has the +/- buttons around the zoom icon, so it looks like they control the zooming.

The second one has the +/- buttons around the dropdown box, so it looks like they control the dropdown (i.e. the duration).

So, as a suggestion, reordering the buttons could make it more intuitive. (And, yes, I realize I'm commenting on a closed issue.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants