Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate candlestick plots #183

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

igorfialko
Copy link
Contributor

I had to change a property on Axis class, because range can be represented as time string in candlestick plot.

//before
range: (Double, Double) = null,
//after
range: Sequence = null,

Also seems like my formatter has a little bit different configuration. So I've left some files unformatted. Formatting is up to you then. Do you use scalafmt?

@alexarchambault
Copy link
Owner

Thanks! There's no scalafmt config yet, formatting is manual for now.

Don't hesitate to try to minimize the diff here for easier review. I can give it a try whenever I'll have time else…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants