Standardise project structure #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project structure was unnecessarily custom. This commit... - removes custom build configurations and assembly attributes; - simplifies the TimeSpeed.csproj and .gitignore files; - switches Json.NET to the version used by SMAPI; - exports pdb files in release builds; - copies the mod into the game's Mods folder automatically on build; - targets .NET Framework 4.5 for crossplatform compatibility.
…ebugger This was presumably needed to attach a debugger manually, which is no longer needed. The new build configuration copies the build files into the game folder and attaches a debugger automatically if applicable.
|
Thanks. Everything looks perfect. |
|
Actually, @Pathoschild, how can I build mod for Linux or Mac while being on Windows with new build config? Previously I copied platform specific binaries to internal directory. |
|
@alexb5dh You don't need to anymore. Just build it once on Windows, and SMAPI will rewrite it automatically when it's loaded on Linux/Mac. :) |
|
That sounds really awesome! Can you point me to the SMAPI code where this magic is done? |
|
The magic happens in SMAPI's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project structure is a bit complicated and non-standard.
This pull request...
Modsfolder automatically on build;TimeSpeed.csprojand.gitignore;.pdbfiles in release builds;This is part I of the update to the latest SMAPI interfaces; let me know if you disagree with any of the changes.