Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings #49

Merged
merged 1 commit into from Aug 26, 2020
Merged

Fix typings #49

merged 1 commit into from Aug 26, 2020

Conversation

saraedum
Copy link
Contributor

@saraedum saraedum commented Jul 8, 2020

Typescript otherwise complains in my setup:

515:21 Parameter 'MultilineEdgeShape' implicitly has an 'any' type.
    513 |     class MultilineEdge extends Edge {
    514 |         shape: MultilineEdgeShape;          // there may be only one line edge and only terminal ray edges
  > 515 |         constructor(MultilineEdgeShape);
        |                     ^
    516 |     }
    517 |
    518 |     class Multiline extends LinkedList {
541:14 'point', which lacks return-type annotation, implicitly has an 'any' return type.
    539 |
    540 |     function point(x?: number, y?: number): Point;
  > 541 |     function point(arr?: [number, number]);
        |              ^
    542 |     function circle(pc: Point, r: number) : Circle;
    543 |     function line(pt?: Point, norm?: Vector) : Line;
    544 |     function line(norm?: Vector, pt?: Point) : Line;

Typescript otherwise complains in my setup:
```
515:21 Parameter 'MultilineEdgeShape' implicitly has an 'any' type.
    513 |     class MultilineEdge extends Edge {
    514 |         shape: MultilineEdgeShape;          // there may be only one line edge and only terminal ray edges
  > 515 |         constructor(MultilineEdgeShape);
        |                     ^
    516 |     }
    517 |
    518 |     class Multiline extends LinkedList {
541:14 'point', which lacks return-type annotation, implicitly has an 'any' return type.
    539 |
    540 |     function point(x?: number, y?: number): Point;
  > 541 |     function point(arr?: [number, number]);
        |              ^
    542 |     function circle(pc: Point, r: number) : Circle;
    543 |     function line(pt?: Point, norm?: Vector) : Line;
    544 |     function line(norm?: Vector, pt?: Point) : Line;
```
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.433% when pulling 8fba716 on saraedum:patch-1 into 7323efb on alexbol99:master.

@alexbol99 alexbol99 merged commit c108a4c into alexbol99:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants