remove deprecated cltv delta value for swap out

alexbosworth · Oct 23, 2020 · 2803b1c · 2803b1c
1 parent b80aa3e
commit 2803b1c
Show file tree

Hide file tree

Showing 13 changed files with 6,107 additions and 44 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,13 @@
 # Versions
 
+## 8.0.0
+
+- `getSwapOutQuote`: remove `cltv_delta` from response
+
+### Breaking Change
+
+- `getSwapOutQuote`: `cltv_delta` is undefined, use the `cltv_delta` from the request instead
+
 ## 7.1.2
 
 - `decodeSwapRecovery`: Pull out version field from recovery details

diff --git a/chain/subscribe_to_blocks.js b/chain/subscribe_to_blocks.js
@@ -17,7 +17,7 @@ const tickDelayMs = 20;
 
   {
     [delay]: <Poll Delay Milliseconds Number> // default 10 minutes
-    [lnd]: <Authenticated LND gRPC Object>
+    [lnd]: <Authenticated LND API Object>
     [network]: <Network Name String>
     [request]: <Request Function>
   }

diff --git a/lightninglabs/create_swap_in.js b/lightninglabs/create_swap_in.js
@@ -33,7 +33,7 @@ const preimageLen = 32;
     [private_key]: <Refund Private Key Hex String>
     [public_key]: <Refund Public Key Hex String>
     request: <BOLT 11 Payment Request String>
-    service: <gRPC Swap Service API Object>
+    service: <Swap Service API Object>
   }
 
   @returns via cbk or Promise

diff --git a/lightninglabs/get_swap_out_quote.js b/lightninglabs/get_swap_out_quote.js
@@ -90,10 +90,6 @@ module.exports = (args, cbk) => {
 
       // Loop out quote
       quote: ['getQuote', ({getQuote}, cbk) => {
-        if (!getQuote.cltv_delta) {
-          return cbk([503, 'ExpectedCltvDeltaInSwapQuoteResponse']);
-        }
-
         if (!getQuote.prepay_amt) {
           return cbk([503, 'ExpectedPrepayAmountInSwapQuoteResponse']);
         }
@@ -107,7 +103,6 @@ module.exports = (args, cbk) => {
         }
 
         return cbk(null, {
-          cltv_delta: getQuote.cltv_delta,
           deposit: Number(getQuote.prepay_amt),
           destination: getQuote.swap_payment_dest,
           fee: Number(getQuote.swap_fee),