New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 3D Touch swiping issue #41
Conversation
updated from alex
@webraptor Hi @webraptor, |
Allright, already tested on simulator and 2 different devices with and without 3D touch |
Thanks alot ! @webraptor @AlexVegner What issue is it fixing ? |
Hi @webraptor @alexbrillant, |
And that one causes swiping not to work at all on simulator and all devices. Does swiping work for you in that scenario ? |
Yes, with #40 swipe worked for my case. Tested on 6+, 7 devices. |
I was able to fix swiping and now working to fix force/3d touch on inner buttons. Will create a PR when finished.
…Sent from my iPhone
On 26 Jul 2017, at 12:52, AlexVegner ***@***.***> wrote:
@webraptor
And that one causes swiping not to work at all on simulator and all devices. Does swiping work for you in that scenario ?
Yes, with #40 swipe worked for my case. Tested on 6+, 7 devices.
I will create test project later today, so we will discuss this issue based on same code base.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@@ -110,6 +110,7 @@ class Swiper extends React.Component { | |||
this._panResponder = PanResponder.create({ | |||
onStartShouldSetPanResponder: (event, gestureState) => true, | |||
onMoveShouldSetPanResponder: (event, gestureState) => false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line partly fixes 3D touch issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -110,6 +110,7 @@ class Swiper extends React.Component { | |||
this._panResponder = PanResponder.create({ | |||
onStartShouldSetPanResponder: (event, gestureState) => true, | |||
onMoveShouldSetPanResponder: (event, gestureState) => false, | |||
onMoveShouldSetPanResponderCapture: (evt, gestureState) => gestureState.dx != 0 && gestureState.dy != 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line fixed manual swiping around (pan responder) on 3D touch devices.
Added a few extra comments on the lines affected by this PR, with info on what they actually do. Inline touch not working?
I am sure there are still some other scenarios, but at least we now know how to fix basic behaviors. |
@webraptor @alexbrillant |
@alexbrillant You could close #33 |
Fix 3D Touch swiping issue
No description provided.