Enable Heroku hosting support by adding a port option. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you left some "puts ARGV"s in there. Otherwise looks great. |
|
Hah, yeah, added this feature in about two minutes because I needed to deploy slides somewhere in 5. I'll clean it up and add a few more commits. |
|
Removed the debug output. Sorry about that. |
alexch
added a commit
that referenced
this pull request
Feb 28, 2012
Enable Heroku hosting support by adding a port option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binary now takes a
-p $PORTor--port $PORToption which is passed to the Rack server. This adds the ability to host Deck on Heroku since without it Deck is not able to be passed the port number on Heroku.There are no tests against the binary.
The option parsing introduces trollop as a dependency.