Use partial-io to shake out Interrupted-related bugs #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndled `partial-io` is a helper library that lets users wrap readers and writers and generate partial reads, or fail with temporary errors like `Interrupted`. It also integrates with `quickcheck` to provide random sequences of test instances. Looks like the read side handles `Interrupted` errors correctly. The write side currently doesn't, and the next commit will fix it.
Make the `BzEncoder` and `BzDecoder` writers retry on `Interrupted` errors rather than bubbling them up. This also means that they now obey `AsyncWrite` rules, which prohibit `Interrupted` errors from being bubbled up. Closes alexcrichton#19.
|
Thanks for the PR! I'm not sure this is the intended purpose though? This changes a few functions to loop on |
|
oops didn't mean to close |
|
Hm, I might be missing something, but Interrupted isn't WouldBlock. If you remember, we decided in tokio-io that AsyncWrites should propagate WouldBlock but retry on Interrupted. |
|
Whoops right yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial-iois a helper library that lets users wrap readers and writers andgenerate partial reads, or fail with temporary errors like
Interrupted. Italso integrates with
quickcheckto provide random sequences of test instances.partial-iofound a bug on the write side: we weren't handlingInterrupted, eventhough
AsyncWriterequires thatInterruptederrors be handled at this layer.Closes #19.