Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GzBuilder methods should take Into<Vec<u8>> #84

Closed
dtolnay opened this issue Apr 4, 2017 · 1 comment
Closed

GzBuilder methods should take Into<Vec<u8>> #84

dtolnay opened this issue Apr 4, 2017 · 1 comment
Labels
easy help wanted

Comments

@dtolnay
Copy link
Member

dtolnay commented Apr 4, 2017

Currently GzBuilder::filename and GzBuilder::comment take &[u8] while GzBuilder::extra takes Vec<u8>.

These would be more consistent and more usable if they all accepted Into<Vec<u8>>.
@dtolnay dtolnay mentioned this issue Apr 4, 2017
Closed
15 tasks
This was referenced Apr 13, 2017
Closed
Merged
@alexcrichton
Copy link
Member

Fixed in #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @brson @dtolnay