Add connect_timeout #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Untested on Windows as I don't have access to a Windows box for a couple days. |
sfackler
force-pushed
the
connect-timeout
branch
3 times, most recently
from
ab7443c
to
aa17f4b
Compare
alexcrichton
reviewed
Jun 8, 2017
src/sys/unix/mod.rs
Outdated
|
|
||
| let timeout = cmp::min(timeout, c_int::max_value() as u64) as c_int; | ||
|
|
||
| let r = unsafe { libc::poll(&mut pollfd, 1, timeout) }; |
There was a problem hiding this comment.
I think this'll want to loop to handle EINTR, right? (or at least that'd what I'd expect a "convenient" implementation to do
There was a problem hiding this comment.
What should we do about the timeout in that situation? Just use the original one, or try to keep it updated with a couple of Instants?
Doesn't everything use SA_RESTART, anyway?
src/sys/unix/mod.rs
Outdated
| } | ||
| } | ||
|
|
||
| self.set_nonblocking(false) |
There was a problem hiding this comment.
Perhaps this could be lifted above the match r to unconditionally happen?
|
Updated |
Unlike the rest of the API, connect_timeout does not correspond to a single API call. However, it's a fundamental operation, and is a pain to set up.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the rest of the API, connect_timeout does not correspond to a
single API call. However, it's a fundamental operation, and is a pain to
set up.