make sure the test runs only on unix like OS's #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
twitzelbos
commented
Sep 21, 2023
twitzelbos
commented
- this should prevent windows tests from failing
|
I admittedly don't know this feature well, but is there any way to modify the test to be able to run on both Windows and *nix? |
|
It will be possible in windows as well, as soon as rust-lang/libs-team#271 lands. |
|
PS: I also know why the MacOS action is going on forever. I have a workaround that I could add to this PR. I also tried raising this on libssh2 itself: |
|
Oops sorry. That was a clumsy mistake. I forgot that needed to be excluded for windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.