Restore create_dir_all method for directory creation #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
klensy
added a commit
to klensy/rust
that referenced
this pull request
Aug 27, 2021
https://rustsec.org/advisories/RUSTSEC-2021-0093 https://github.com/crossbeam-rs/crossbeam/pull/728/files openssl-src v111.15.0+1.1.1k -> v111.16.0+1.1.1l: https://rustsec.org/advisories/RUSTSEC-2021-0097 https://rustsec.org/advisories/RUSTSEC-2021-0098 https://www.openssl.org/news/vulnerabilities-1.1.1.html tar v0.4.35 -> v0.4.37: https://rustsec.org/advisories/RUSTSEC-2021-0080 updated to 0.4.37 as there breaking change in 0.4.36: alexcrichton/tar-rs#260
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 29, 2021
…acrum
Bump vulnerable crates
crossbeam-deque v0.7.3 -> v0.7.4:
https://rustsec.org/advisories/RUSTSEC-2021-0093
https://github.com/crossbeam-rs/crossbeam/pull/728/files
openssl-src v111.15.0+1.1.1k -> v111.16.0+1.1.1l:
https://rustsec.org/advisories/RUSTSEC-2021-0097
https://rustsec.org/advisories/RUSTSEC-2021-0098
https://www.openssl.org/news/vulnerabilities-1.1.1.html
tar v0.4.35 -> v0.4.37:
https://rustsec.org/advisories/RUSTSEC-2021-0080
updated to 0.4.37 as there breaking change in 0.4.36: alexcrichton/tar-rs#260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/alexcrichton/tar-rs/releases/tag/0.4.36 can be breaking for callers using
unpack_in()to unpack to the same directory in parallel. If multiple threads race to create the same parent, the later ones will now error; #259 switches tocreate_dir(), which errors if a folder already exists.With the new validation added in #259 , it seems reasonable to restore
create_dir_all()for the actual creation. What do you think?