Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entry: Use strip_prefix #329

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

cgwalters
Copy link
Contributor

Minor drive by code cleanup; strip_prefix is just more readable and more bug-resistant than manually doing it with starts_with combined with slicing.

Minor drive by code cleanup; `strip_prefix` is just more readable
and more bug-resistant than manually doing it with
`starts_with` combined with slicing.
@cgwalters
Copy link
Contributor Author

@alexcrichton This crate is currently very important to some software I maintain; I'd probably be able to act as a 20%-time co-maintainer. Maybe what we could do is find a few other interested parties, and switch things so that merging a PR requires 2 approving reviews? Looking at the outstanding PRs there are some other people in the list that I'd trust to be co-maintainers too, e.g. @sunshowers.

@alexcrichton
Copy link
Owner

Thank you for the offer! I would be happy to have help maintaining this crate as I think I clearly can't offer the support it needs.

If y'all would like would you be ok if I sort of "phased y'all in" over time? For example would you be ok reviewing PRs and then pinging me when it's ready to merge? After a few PRs I can give y'all write access to merge PRs yourselves and then you'd only need to ping me for releases. After a release or two perhaps I could invite y'all to crates.io to publish without me as well.

@cgwalters
Copy link
Contributor Author

If y'all would like would you be ok if I sort of "phased y'all in" over time? For example would you be ok reviewing PRs and then pinging me when it's ready to merge?

Yes definitely. I tried to figure out a way to coerce the Github search to list "PRs reviewed and approved by @cgwalters" (or an arbitrary set of other users) but it only does "PRs that were approved" which isn't the same thing.

Anyways here's my list of PRs that I believe are good:

What you may also find useful as a reference is PRs for which I didn't approve or requested changes to see if we agree on architecture:

@alexcrichton
Copy link
Owner

All looks great, thank you again for your help here, it's very much appreciated! Feel free to ping me for merging those PRs when they're ready and I'll do a final once-over, your comments look good to me.

It's also been awhile since a release has been made, if you're up for it mind opening a PR with a version bump? I can publish to crates.io after when it's ready.

@alexcrichton alexcrichton merged commit 2224f6e into alexcrichton:main Jun 4, 2024
6 of 7 checks passed
ararslan pushed a commit to ararslan/binstall-tar that referenced this pull request Jun 6, 2024
Minor drive by code cleanup; `strip_prefix` is just more readable
and more bug-resistant than manually doing it with
`starts_with` combined with slicing.

(cherry picked from commit 2224f6e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants