Address Ruby 2.8 #untaint deprecation warnings #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composerinteralia
force-pushed
the
ruby-2.7-untaint-warning
branch
2 times, most recently
from
c386516
to
7e8fbe4
Compare
Prior to this commit we were seeing errors when calling the deprecated Object#untaint method on Ruby 2.8. The method is a no-op on Ruby 2.8. ```rb dnsruby/config.rb:325: warning: Object#untaint is deprecated and will be removed in Ruby 3.2 ``` We probably could remove untainting for older Ruby versions as well, but it felt safer to preserve the current behavior in case someone is still relying on it. To see this change in action, we added ruby-head to the travis matrix, but do not require those tests to pass for the build as a whole to pass. See https://bugs.ruby-lang.org/issues/16131 for details on the deprecation. Co-authored-by: Adam Hess <hparker@github.com>
composerinteralia
force-pushed
the
ruby-2.7-untaint-warning
branch
from
7e8fbe4
to
454e0a6
Compare
composerinteralia
changed the title
|
Great - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit we were seeing errors when calling the deprecated
Object#untaint method on Ruby 2.8. The method is a no-op on Ruby 2.8.
We probably could remove untainting for older Ruby versions as well, but
it felt safer to preserve the current behavior in case someone is still
relying on it.
To see this change in action, we added ruby-head to the travis matrix,
but do not require those tests to pass for the build as a whole to pass.
See https://bugs.ruby-lang.org/issues/16131 for details on the
deprecation.