Questions about prune(view)

[hfossli]

Hey. Nice work!

I have not used your framework yet. I've only read the source as I have another closed source project (closed for now) in objc which also takes great inspiration from react.

About this method:

Render/Render/ComponentView.swift

Lines 71 to 79 in a6c7086

	func prune(view: UIView) {
	if !viewSet.contains(view) {
	view.removeFromSuperview() //todo: put in a global reusable pool?
	} else {
	for subview in view.subviews where subview.hasFlexNode {
	prune(subview)
	}
	}
	}

A UIScrollView has two UIImageView's as subviews – the scroll indicators. There are many types of views which uses subviews internally. UIButton, UITableView, etc etc. Do you take that into account when reusing views?

In my framework I'm thinking that I might need to have separate rules for reusing and splitting up the different types of views depending on its structure.

[alexdrone]

The diff algorithm works with the componentNodes and not with the views.. So the granularity is different. Every node has a view associated (and that can be a complex view hierarchy per se) - the infra won't be touching views that are subviews of the node root view.

[hfossli]

I see. Clever 👌🏼