Fixed typo in holidays_by_month. #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't know how to regenerate the file, fixed by hand.
|
Hi, i have forgotten to change/regenerate the sk.rb definitions in my first pull request. It was needed for proper function when the gem is installed from master branch. Sorry :). |
1 similar comment
|
Did not read the docs (regeneration part), this pull request does not make sense. Closing. Sorry. |
Murphydbuffalo
pushed a commit
to Murphydbuffalo/holidays
that referenced
this pull request
Sep 21, 2021
Add tests for Civic Holiday (Terry Fox Day) for ca_mb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know how to regenerate the file, fixed by hand.