Test with modern Ruby release #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows the build to go green again and includes a few changes: * Simplify the test matrix by only testing Ruby 2.5.3 (for now). Needs discussion by maintainers. * Fixnums are now Integers * Allow bundler 1.x or 2.x
|
@alexduryee The build passes now: https://travis-ci.org/alexduryee/timetwister/builds/595676034 Not sure why GitHub is not showing the checks above? Maybe the Travis/GitHub integration needs to be tweaked/updated. |
|
I've no strong feelings about dropping Travis support for older Rubies, so this is fine by me. Dunno why the CI badge is listing an error; it seems like it's a problem with the 1.9.3 build, so dropping that should clear it up. |
|
@alexduryee It looks like this repo is no longer integrated with Travis, so the build failure up above is from a way old build. I can work on this if you are OK with granting me access to this repo. I'm comfy doing whatever here, so you know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the build to go green again and includes a few changes: