fix(executor): Do not delete local artifacts after upload. Fixes argo…

…proj#4676

Signed-off-by: Alex Collins <alex_collins@intuit.com>

workflow/executor/executor.go

@@ -340,16 +340,25 @@ func (we *WorkflowExecutor) saveArtifact(mainCtrID string, art *wfv1.Artifact) e
 	if err != nil {
 		return err
 	}
-	// remove is best effort (the container will go away anyways).
-	// we just want reduce peak space usage
-	err = os.Remove(localArtPath)
-	if err != nil {
-		log.Warnf("Failed to remove %s: %v", localArtPath, err)
-	}
+	we.maybeDeleteLocalArtPath(localArtPath)
 	log.Infof("Successfully saved file: %s", localArtPath)
 	return nil
 }
 
+func (we *WorkflowExecutor) maybeDeleteLocalArtPath(localArtPath string) {
+	if os.Getenv("REMOVE_LOCAL_ART_PATH") == "true" {
+		log.WithField("localArtPath", localArtPath).Info("deleting local artifact")
+		// remove is best effort (the container will go away anyways).
+		// we just want reduce peak space usage
+		err := os.Remove(localArtPath)
+		if err != nil {
+			log.Warnf("Failed to remove %s: %v", localArtPath, err)
+		}
+	} else {
+		log.WithField("localArtPath", localArtPath).Info("not deleting local artifact")
+	}
+}
+
 // stageArchiveFile stages a path in a container for archiving from the wait sidecar.
 // Returns a filename and a local path for the upload.
 // The filename is incorporated into the final path when uploading it to the artifact repo.