Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

significant code refactoring #211

Merged
merged 40 commits into from
Nov 18, 2021
Merged

significant code refactoring #211

merged 40 commits into from
Nov 18, 2021

Conversation

alexei-led
Copy link
Owner

  • use golangci-lint linter
  • fix violations for multiple linters
  • align CLI flag names (no Camel case)
  • use time.Duration for duration CLI flags
  • remove unused code
  • refactor code to reduce duplications

@alexei-led alexei-led self-assigned this Nov 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #211 (9a13db7) into master (ddb0ce3) will decrease coverage by 1.90%.
The diff coverage is 20.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   42.01%   40.11%   -1.91%     
==========================================
  Files          37       37              
  Lines        1478     1249     -229     
==========================================
- Hits          621      501     -120     
+ Misses        857      748     -109     
Impacted Files Coverage Δ
pkg/chaos/command.go 0.00% <0.00%> (ø)
pkg/chaos/docker/cmd/exec.go 16.66% <0.00%> (+2.38%) ⬆️
pkg/chaos/docker/cmd/kill.go 14.28% <0.00%> (ø)
pkg/chaos/docker/cmd/pause.go 14.28% <0.00%> (ø)
pkg/chaos/docker/cmd/remove.go 14.28% <0.00%> (+1.78%) ⬆️
pkg/chaos/docker/cmd/restart.go 16.66% <0.00%> (+3.33%) ⬆️
pkg/chaos/docker/cmd/stop.go 12.50% <0.00%> (ø)
pkg/chaos/netem/cmd/corrupt.go 11.76% <0.00%> (+2.67%) ⬆️
pkg/chaos/netem/cmd/delay.go 10.52% <0.00%> (+2.19%) ⬆️
pkg/chaos/netem/cmd/duplicate.go 11.76% <0.00%> (+2.67%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddb0ce3...9a13db7. Read the comment docs.

@alexei-led alexei-led merged commit 22eaa60 into master Nov 18, 2021
@alexei-led alexei-led deleted the fix/linters branch November 18, 2021 18:47
aminvakil added a commit to aminvakil/aur that referenced this pull request Nov 19, 2021
aminvakil added a commit to aminvakil/aur that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants