Get the client source docker socket path dynamically #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexei-led
requested changes
Apr 27, 2022
pkg/container/client.go
Outdated
| @@ -11,6 +11,8 @@ import ( | |||
| "strings" | |||
| "time" | |||
|
|
|||
| "unsafe" | |||
There was a problem hiding this comment.
Please format code with goimports and run make lint to check if it properly formatted
pkg/container/client.go
Outdated
| @@ -652,6 +654,11 @@ func (client dockerClient) tcContainerCommand(ctx context.Context, target *Conta | |||
| return nil | |||
| } | |||
|
|
|||
|
|
|||
| func GetUnexportedField(field reflect.Value) string { | |||
There was a problem hiding this comment.
Please, do not use reflection to expose the internal field.
Consider doing this explicitly.
- Add a new
host-socketparameter to the stress command (NewStressCLICommand) - Default to
/var/run/docker.sock - Pass it to the
stressContainerCommandfunction
pkg/container/client.go
Outdated
| @@ -652,6 +654,11 @@ func (client dockerClient) tcContainerCommand(ctx context.Context, target *Conta | |||
| return nil | |||
| } | |||
|
|
|||
|
|
|||
| func GetUnexportedField(field reflect.Value) string { | |||
There was a problem hiding this comment.
Please, do not use reflection to expose the internal field.
Consider doing this explicitly.
- Add a new
host-socketparameter to the stress command (NewStressCLICommand) - Default to
/var/run/docker.sock - Pass it to the
stressContainerCommandfunction
There was a problem hiding this comment.
Hello @alexei-led, it seem adding new parameter break this function:
Line 66 in cd6983d
How can I deal with ?
There was a problem hiding this comment.
I added the parameter:
# ./pumba stress --help
NAME:
pumba stress - stress test a specified containers
USAGE:
pumba stress [command options] containers (name, list of names, or RE2 regex if prefixed with "re2:")
DESCRIPTION:
stress test target container(s)
OPTIONS:
--duration value, -d value stress duration: must be shorter than recurrent interval; use with optional unit suffix: 'ms/s/m/h'
--stress-image value Docker image with stress-ng tool, cgroup-bin and docker packages, and dockhack script (default: "alexeiled/stress-ng:latest-ubuntu")
--pull-image pull stress-image form Docker registry
--stressors value stress-ng stressors; see https://kernel.ubuntu.com/~cking/stress-ng/ (default: "--cpu 4 --timeout 60s")
--host-socket value daemon socket to connect to (default: "/var/run/docker.sock") [$DOCKER_HOST]
If I use the parameter, I get this output:
# ./pumba --log-level debug --label test=chaos stress --duration 60s --stress-image chaos/pumba:0.2.0 --stressors "--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s" --host-socket /var/run/docker.sock
DEBU[0000] using names names="[/var/run/docker.sock --cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]"
DEBU[0000] stress testing all matching containers
DEBU[0000] listing matching containers duration=1m0s labels="[test=chaos]" limit=0 names="[/var/run/docker.sock --cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]" pattern= random=false stressors="[--host-socket]"
DEBU[0000] listing containers
DEBU[0000] found container id=2618ac158889440c4b0764c55cb5ffb69dd650f1aa870ea99bc2fb5b95652b1e name=/keen_heyrovsky
WARN[0000] no containers to stress test
If I remove the flag, its seem work:
# ./pumba --log-level debug --label test=chaos stress --duration 60s --stress-image chaos/pumba:0.2.0 --stressors "--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s"
DEBU[0000] stress testing all matching containers
DEBU[0000] listing matching containers duration=1m0s labels="[test=chaos]" limit=0 names="[]" pattern= random=false stressors="[--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]"
DEBU[0000] listing containers
DEBU[0000] found container id=2618ac158889440c4b0764c55cb5ffb69dd650f1aa870ea99bc2fb5b95652b1e name=/keen_heyrovsky
DEBU[0000] stress testing container for duration container=2618ac158889440c4b0764c55cb5ffb69dd650f1aa870ea99bc2fb5b95652b1e duration=1m0s pull image=true stress-ng image="chaos/pumba:0.2.0" stressors="[--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]"
INFO[0000] stress testing container dryrun=false duration=1m0s id=2618ac158889440c4b0764c55cb5ffb69dd650f1aa870ea99bc2fb5b95652b1e image="chaos/pumba:0.2.0" name=/keen_heyrovsky pull=true stressors="[--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]"
DEBU[0000] executing stress-ng command image="chaos/pumba:0.2.0" pull=true stressors="[--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]" target=2618ac158889440c4b0764c55cb5ffb69dd650f1aa870ea99bc2fb5b95652b1e
DEBU[0000] pulling stress-ng image image="chaos/pumba:0.2.0"
DEBU[0000] &{Pulling from chaos/pumba {0 0}}
DEBU[0000] &{Digest: sha256:6b0150ed9a2a75539b6dd8cdd48d65e32fd124eb257919ef5f9bf3d0a820a59a {0 0}}
DEBU[0000] &{Status: Image is up to date for chaos/pumba:0.2.0 {0 0}}
DEBU[0000] creating stress-ng container image="chaos/pumba:0.2.0"
DEBU[0000] stress-ng container created, starting it id=f5d9e6c5cd67e2da457c52cce901ecf821517409507e95ec62f4678026708ce2
There was a problem hiding this comment.
Well, switch parameter order seem make it work...
No --host-socket parameter -> bind source path does not exist: /var/run/docker.sock
# ./pumba \
--host unix:///var/run/docker-test.sock \
--log-level debug \
--label test=chaos \
stress \
--duration 60s \
--stress-image chaos/pumba:0.2.0 \
--stressors "--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s"
DEBU[0000] stress testing all matching containers
DEBU[0000] listing matching containers duration=1m0s labels="[test=chaos]" limit=0 names="[]" pattern= random=false stressors="[--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]"
DEBU[0000] listing containers
DEBU[0000] found container id=fdefca0776411b2561cb33a27d9d4088270a75cb085682328102f2decb86c35d name=/determined_moore
DEBU[0000] stress testing container for duration container=fdefca0776411b2561cb33a27d9d4088270a75cb085682328102f2decb86c35d duration=1m0s pull image=true stress-ng image="chaos/pumba:0.2.0" stressors="[--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]"
INFO[0000] stress testing container dryrun=false duration=1m0s id=fdefca0776411b2561cb33a27d9d4088270a75cb085682328102f2decb86c35d image="chaos/pumba:0.2.0" name=/determined_moore pull=true stressors="[--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]"
DEBU[0000] executing stress-ng command image="chaos/pumba:0.2.0" pull=true stressors="[--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]" target=fdefca0776411b2561cb33a27d9d4088270a75cb085682328102f2decb86c35d
DEBU[0000] pulling stress-ng image image="chaos/pumba:0.2.0"
DEBU[0000] &{Pulling from chaos/pumba {0 0}}
DEBU[0000] &{Digest: sha256:6b0150ed9a2a75539b6dd8cdd48d65e32fd124eb257919ef5f9bf3d0a820a59a {0 0}}
DEBU[0000] &{Status: Image is up to date for chaos/pumba:0.2.0 {0 0}}
DEBU[0000] creating stress-ng container image="chaos/pumba:0.2.0"
FATA[0000] error running stress command: error running chaos command: one or more stress test failed: stress test failed: failed to create stress-ng container: Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /var/run/docker.sock
Using --host-socket as last parameter -> no containers to stress test
# ./pumba \
--host unix:///var/run/docker-test.sock \
--log-level debug \
--label test=chaos \
stress \
--duration 60s \
--stress-image chaos/pumba:0.2.0 \
--stressors "--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s" \
--host-socket /var/run/docker-test.sock
DEBU[0000] using names names="[/var/run/docker.sock --cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]"
DEBU[0000] stress testing all matching containers
DEBU[0000] listing matching containers duration=1m0s labels="[test=chaos]" limit=0 names="[/var/run/docker.sock --cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]" pattern= random=false stressors="[--host-socket]"
DEBU[0000] listing containers
DEBU[0000] found container id=fdefca0776411b2561cb33a27d9d4088270a75cb085682328102f2decb86c35d name=/determined_moore
WARN[0000] no containers to stress test
Using --host-socket as third parameter -> it work
(I dont have dockhack installed on my computer)
# ./pumba \
--host unix:///var/run/docker-test.sock \
--log-level debug \
--label test=chaos \
stress \
--duration 60s \
--stress-image chaos/pumba:0.2.0 \
--host-socket /var/run/docker-test.sock \
--stressors "--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s"
DEBU[0000] stress testing all matching containers
DEBU[0000] listing matching containers duration=1m0s labels="[test=chaos]" limit=0 names="[]" pattern= random=false stressors="[--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]"
DEBU[0000] listing containers
DEBU[0000] found container id=fdefca0776411b2561cb33a27d9d4088270a75cb085682328102f2decb86c35d name=/determined_moore
DEBU[0000] stress testing container for duration container=fdefca0776411b2561cb33a27d9d4088270a75cb085682328102f2decb86c35d duration=1m0s pull image=true stress-ng image="chaos/pumba:0.2.0" stressors="[--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]"
INFO[0000] stress testing container dryrun=false duration=1m0s id=fdefca0776411b2561cb33a27d9d4088270a75cb085682328102f2decb86c35d image="chaos/pumba:0.2.0" name=/determined_moore pull=true stressors="[--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]"
DEBU[0000] executing stress-ng command image="chaos/pumba:0.2.0" pull=true stressors="[--cpu 1 --vm 1 --vm-bytes 500M --timeout 30s]" target=fdefca0776411b2561cb33a27d9d4088270a75cb085682328102f2decb86c35d
DEBU[0000] pulling stress-ng image image="chaos/pumba:0.2.0"
DEBU[0000] &{Pulling from chaos/pumba {0 0}}
DEBU[0000] &{Digest: sha256:6b0150ed9a2a75539b6dd8cdd48d65e32fd124eb257919ef5f9bf3d0a820a59a {0 0}}
DEBU[0000] &{Status: Image is up to date for chaos/pumba:0.2.0 {0 0}}
DEBU[0000] creating stress-ng container image="chaos/pumba:0.2.0"
DEBU[0000] stress-ng container created, starting it id=f5454b4d71e4082520814e66d364315bba60066d81036df1c6f0e66afe4153bd
FATA[0000] error running stress command: error running chaos command: one or more stress test failed: stress test failed: failed to start stress-ng container: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "dockhack": executable file not found in $PATH: unknown
This is kinda dirty...
pkg/container/client.go
Outdated
| @@ -674,7 +681,7 @@ func (client dockerClient) stressContainerCommand(ctx context.Context, targetID | |||
| // docker socket mount | |||
| dockerSocket := mount.Mount{ | |||
| Type: mount.TypeBind, | |||
| Source: "/var/run/docker.sock", | |||
| Source: GetUnexportedField(reflect.ValueOf(client.containerAPI).Elem().FieldByName("addr")), | |||
pkg/container/client.go
Outdated
| @@ -674,7 +681,7 @@ func (client dockerClient) stressContainerCommand(ctx context.Context, targetID | |||
| // docker socket mount | |||
| dockerSocket := mount.Mount{ | |||
| Type: mount.TypeBind, | |||
| Source: "/var/run/docker.sock", | |||
| Source: GetUnexportedField(reflect.ValueOf(client.containerAPI).Elem().FieldByName("addr")), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a fix proposal.
Cause you are using "client" as variable name, you had to ovewrite the docker client lib as dockerapi.
Cause dockerapi.NewClientWithOpts return client.Client object, we cant use method and field on this object.
The simpliest way I found to get the object field value is to use "unsafe" to catch the unreferenced field in a "reflect" object of the client.Client
The communication look working with the socket now.
Fix #218
Signed-off-by: Remi Ziolkowski remi.ziolkowski-ext@pole-emploi.fr