fix #192 - remove String.repeat usage to remove IE11 polyfill requirement #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwalk33r
commented
Apr 4, 2020
| @@ -79,8 +79,8 @@ describe('sprintfjs', function() { | |||
| assert.equal('3.14159', sprintf('%.6g', pi)) | |||
| assert.equal('3.14', sprintf('%.3g', pi)) | |||
| assert.equal('3', sprintf('%.1g', pi)) | |||
There was a problem hiding this comment.
Only those 2 tests below seem to care about this so far.
ashwalk33r
commented
Apr 4, 2020
| @@ -131,7 +131,7 @@ | |||
| } | |||
| pad_character = ph.pad_char ? ph.pad_char === '0' ? '0' : ph.pad_char.charAt(1) : ' ' | |||
| pad_length = ph.width - (sign + arg).length | |||
| pad = ph.width ? (pad_length > 0 ? pad_character.repeat(pad_length) : '') : '' | |||
| pad = ph.width ? (pad_length > 0 ? new Array(pad_length + 1).join(pad_character) : '') : '' | |||
There was a problem hiding this comment.
This might be concern of optimization - native String.repeat I assume is not only faster but also simpler.
It could also do a feature check:
pad = ph.width ? (pad_length > 0 ? String.prototype.hasOwnProperty('repeat') ? pad_character.repeat(pad_length) : new Array(pad_length + 1).join(pad_character) : '') : ''
ashwalk33r
commented
Apr 4, 2020
| @@ -131,7 +131,7 @@ | |||
| } | |||
| pad_character = ph.pad_char ? ph.pad_char === '0' ? '0' : ph.pad_char.charAt(1) : ' ' | |||
| pad_length = ph.width - (sign + arg).length | |||
| pad = ph.width ? (pad_length > 0 ? pad_character.repeat(pad_length) : '') : '' | |||
| pad = ph.width ? (pad_length > 0 ? new Array(pad_length + 1).join(pad_character) : '') : '' | |||
There was a problem hiding this comment.
Funny thiats similar solution to one removed 4ed9a44#diff-13ed28d46a5f76f4d44561850bda81bbL222
|
I've seen this before and I've made it clear this is not going to happen. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #192