Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minio app - generated secret key might fail to be parsed #47

Closed
kadern0 opened this issue Mar 10, 2020 · 1 comment
Closed

Minio app - generated secret key might fail to be parsed #47

kadern0 opened this issue Mar 10, 2020 · 1 comment

Comments

@kadern0
Copy link
Contributor

kadern0 commented Mar 10, 2020

If the user doesn't provide --secret-key, one will be generated. With current setup, some special characters might end up in the key and this will fail later on as it won't be parsed properly:

Expected Behaviour

Not failing on parsing the secret-key

Current Behaviour

./arkade install minio
Using kubeconfig: /home/kaderno/.kube/config
Client: x86_64, Linux
2020/03/09 20:37:39 User dir established as: /home/kaderno/.arkade/
Hang tight while we grab the latest from your chart repositories...
...Skip local chart repository
...Successfully got an update from the "stable" chart repository
Update Complete.
Access Key not provided, one will be generated for you
Secret Key not provided, one will be generated for you
Error: failed parsing --set data: key "?wD-QGQpEq8V6O1FT" has no value
Error: exit code 1, stderr: Error: failed parsing --set data: key "?wD-QGQpEq8V6O1FT" has no value
21:04

Possible Solution

I think the easiest and fastest solution is to disable the special characters on the generate.Password function call.

Steps to Reproduce (for bugs)

  1. run ./arkade install minio a few times until the key contains a special character like ','

Changing the function to: password.Generate(40, 10, 0, false, true) will solve the problem.

@kadern0
Copy link
Contributor Author

kadern0 commented Mar 16, 2020

Fixed by #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant