Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for emojis and foreign languages #1

Closed
wants to merge 2 commits into from
Closed

Adding support for emojis and foreign languages #1

wants to merge 2 commits into from

Conversation

spekulatius
Copy link

Hey @alexellis

as discussed, the PR for your consideration. It's largely based on https://developers.google.com/web/tools/puppeteer/troubleshooting#running_puppeteer_in_docker

Cheers,
Peter

Signed-off-by: Peter Thaleikis <peter.thaleikis@gmail.com>
@alexellis
Copy link
Owner

What's the difference in Docker image size before/after?

@spekulatius
Copy link
Author

According to docker hubs information it changes from:

image

to

image

Quite a jump, not sure if I can get it smaller. Might be okay. After all , it's installing fonts for the rest of the world. Any ideas on how to reduce the size?

Signed-off-by: Peter Thaleikis <peter.thaleikis@gmail.com>
@alexellis
Copy link
Owner

Please can you use the additional packages method instead?

Simply run the commands that don't fit into the pattern in the single base Dockerfile and let's retain only one template to avoid so much repetition.

@alexellis alexellis closed this in 5045f6d Feb 10, 2021
@alexellis
Copy link
Owner

I've gone ahead and made the changes myself, please see 5045f6d which you are welcome to continue using under the terms of the license.

@spekulatius
Copy link
Author

Thanks for taking care of this - I had it on my todo list after the launch. Slowly catching up...

No worries, the license is and was always considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants