-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/typescript d #15
Open
alexewerlof
wants to merge
2
commits into
master
Choose a base branch
from
feat/typescript-d
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/** | ||
* A function that will be called with the cli args skipping the first two from process.argv | ||
* (ie. node and script name are not passed) | ||
* This function may return a promise | ||
*/ | ||
type AsyncMain = (...args: string[]) => any | ||
|
||
/** | ||
* A function that will be called with an error that may be thrown | ||
* This function may return a promise | ||
*/ | ||
type ErrorHandler = (error: Error) => any | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The return type of this should be |
||
|
||
/** | ||
* Calls a function asynchronously and optionally passes any error to the error handler | ||
* This function will return after asyncMain is executed or in case of error, the | ||
* errorHandler is executed. | ||
* | ||
* @param main a function that will be executed asynchronously. | ||
* It can be an `async` or *sync* (traditional) function. | ||
* If there's an error the `errorHandler` will be called. | ||
* The `main` function will get the CLI arguments as its parameters in the order they were typed by | ||
* the user. | ||
* When you first call `am`, it will listen to `unhandledRejection` event and prints the error | ||
* message referring to the failed promise and sets the `process.exitCode` to `2`. | ||
* The default or provided `errorHandler` will not be called (that way you can call `am()` as many | ||
* times as needed) | ||
* @param errorHandler an optional `async` or *sync* (traditional) function that'll be called if | ||
* the `main()` function throws. It takes the error as its argument. Even if you provide your custom | ||
* error handler, we still set the `process.exitCode` to `1` if you forget to set it to a non-zero | ||
* value. | ||
* Also, if your custom `errorHandler` throws for whatever reason, `am` will use its default error | ||
* handler. | ||
* If you don't provide an error handler a default one will be used which merely logs the error | ||
* using `console.error()` | ||
*/ | ||
declare function am(main: AsyncMain, errorHandler?: ErrorHandler): Promise<ReturnType<AsyncMain>>; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should just be |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return type of this should be
void
no?