Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/typescript d #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 2 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ _Its main use case is for creating Node CLIs._
* 🏳 Works with `async` functions, native or custom promises
* 💌 Passes arguments as parameters to the main function
* 💊 Supports custom error handlers
* 📦 Typescript types are included out of the box

### Install

Expand Down Expand Up @@ -95,14 +96,7 @@ am(async function main(...cliArgs) {

# API

`am(main, errorHandler?): void`

* `main` is an `async` or *sync* (traditional) function. If there's an error the `errorHandler` will be called, otherwise a default error handler will be used which prints the error and sets the `process.exitCode` to `1`.
* The `main` function will get the CLI arguments as its parameters in the order they were typed by the user.
* When you first call `am`, it will listen to `unhandledRejection` event and prints the error message referring to the failed promise and sets the `process.exitCode` to `2`. The default or provided `errorHandler` will not be called (that way you can call `am()` as many times as needed)
* `errorHandler` an optional `async` or *sync* (traditional) function that'll be called if the `main()` function throws. It takes the error as its argument. Even if you provide your custom error handler, we still set the `process.exitCode` to `1` if you forget to set it to a non-zero value. Also, if your custom `errorHandler` throws for whatever reason, `am` will use its default error handler.

The `am()` function returns a promise which always resolves to the value returned from `main()`.
See the [typescript definition](index.d.ts)

---

Expand Down
37 changes: 37 additions & 0 deletions index.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/**
* A function that will be called with the cli args skipping the first two from process.argv
* (ie. node and script name are not passed)
* This function may return a promise
*/
type AsyncMain = (...args: string[]) => any

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type of this should be void no?


/**
* A function that will be called with an error that may be thrown
* This function may return a promise
*/
type ErrorHandler = (error: Error) => any

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type of this should be void no?


/**
* Calls a function asynchronously and optionally passes any error to the error handler
* This function will return after asyncMain is executed or in case of error, the
* errorHandler is executed.
*
* @param main a function that will be executed asynchronously.
* It can be an `async` or *sync* (traditional) function.
* If there's an error the `errorHandler` will be called.
* The `main` function will get the CLI arguments as its parameters in the order they were typed by
* the user.
* When you first call `am`, it will listen to `unhandledRejection` event and prints the error
* message referring to the failed promise and sets the `process.exitCode` to `2`.
* The default or provided `errorHandler` will not be called (that way you can call `am()` as many
* times as needed)
* @param errorHandler an optional `async` or *sync* (traditional) function that'll be called if
* the `main()` function throws. It takes the error as its argument. Even if you provide your custom
* error handler, we still set the `process.exitCode` to `1` if you forget to set it to a non-zero
* value.
* Also, if your custom `errorHandler` throws for whatever reason, `am` will use its default error
* handler.
* If you don't provide an error handler a default one will be used which merely logs the error
* using `console.error()`
*/
declare function am(main: AsyncMain, errorHandler?: ErrorHandler): Promise<ReturnType<AsyncMain>>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just be Promise<void> since AsyncMain's return type doesn't change.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"version": "1.1.0",
"description": "A simple and light way to run a main function asynchronously",
"main": "index.js",
"types": "index.d.ts",
"keywords": [
"async",
"await",
Expand Down