(XXX) Malloc vector (to trigger SIGSEGV)

Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
alexeykudinkin · Mar 7, 2024 · 3d8b154 · 3d8b154
1 parent aa3eb08
commit 3d8b154
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/src/ray/core_worker/transport/direct_actor_transport.cc b/src/ray/core_worker/transport/direct_actor_transport.cc
@@ -94,17 +94,22 @@ void CoreWorkerDirectTaskReceiver::HandleTask(
 
     std::vector<std::pair<ObjectID, std::shared_ptr<RayObject>>> return_objects;
     std::vector<std::pair<ObjectID, std::shared_ptr<RayObject>>> dynamic_return_objects;
-    std::vector<std::pair<ObjectID, bool>> streaming_generator_returns;
+
+    std::vector<std::pair<ObjectID, bool>> *streaming_generator_returns = new std::vector<std::pair<ObjectID, bool>>();
+
     bool is_retryable_error = false;
     std::string application_error = "";
     auto status = task_handler_(task_spec,
                                 resource_ids,
                                 &return_objects,
                                 &dynamic_return_objects,
-                                &streaming_generator_returns,
+                                streaming_generator_returns,
                                 reply->mutable_borrowed_refs(),
                                 &is_retryable_error,
                                 &application_error);
+
+    std::cout << ">>> [CoreWorkerDirectTaskReceiver::HandleTask[accept_callback]] Left task handler: " << task_spec.DebugString() << std::endl;
+
     reply->set_is_retryable_error(is_retryable_error);
     reply->set_is_application_error(!application_error.empty());
     if (!status.ok()) {
@@ -118,7 +123,7 @@ void CoreWorkerDirectTaskReceiver::HandleTask(
       reply->set_task_execution_error(application_error);
     }
 
-    for (const auto &it : streaming_generator_returns) {
+    for (const auto &it : *streaming_generator_returns) {
       const auto &object_id = it.first;
       bool is_plasma_object = it.second;
       auto return_id_proto = reply->add_streaming_generator_return_ids();
@@ -205,6 +210,10 @@ void CoreWorkerDirectTaskReceiver::HandleTask(
       RAY_CHECK(objects_valid);
       send_reply_callback(status, nullptr, nullptr);
     }
+
+    delete streaming_generator_returns;
+
+    std::cout << ">>> [CoreWorkerDirectTaskReceiver::HandleTask[accept_callback]] Completed" << std::endl;
   };
 
   auto cancel_callback = [reply, task_spec](const Status &status,