Pre-empted driver quitting with a .close #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See mozilla/geckodriver#1151. It looks like at least Firefox will annoyingly remain open if a page has certain kinds of modal dialogs. Although it's a teeny bit messy, I don't think it can hurt to _really_ close the browser.
|
I hope this also fixes an issue with Safari that I've observed a while ago. Let me check the changes locally, before merging this in. Thanks for doing this! |
|
Ping @alexeyraspopov - any update? 😊 |
|
Added another fix here: sometimes, if there's an error in setup, Solution: check |
|
....and this opens #8. 😂 Edited PR to address it preemptively. |
|
Sorry for this huge delay. I didn't have enough time to continue this project. I'm really sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See mozilla/geckodriver#1151. It looks like at least Firefox will annoyingly remain open if a page has certain kinds of modal dialogs.
Although it's a teeny bit messy, I don't think it can hurt to really close the browser.