Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #3

Closed
ai opened this issue Sep 27, 2021 · 2 comments
Closed

Add tests #3

ai opened this issue Sep 27, 2021 · 2 comments

Comments

@ai
Copy link
Contributor

ai commented Sep 27, 2021

We need tests to avoid regressions.

Feel free to copy Nano Colors tests (they were written from scratch, I didn’t copy them from anywhere).
@alexeyraspopov
Copy link
Owner

Now that v0.1.0 is out with proper testing against different Node.js version, I'm keeping this issue open to track effort related to covering NO_COLOR (and related flags/vars) support.

@alexeyraspopov
Copy link
Owner

Final piece is here: 9002f13. I've adopted the test cases from nanocolors to test isColorSupported flag. The script takes less than a second so I just put it as a part of benchmarks job just because it already uses Node v16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ai @alexeyraspopov